adding support for labels in deployment.yaml and update readme #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanes
reviewed
Feb 3, 2025
|
Does this need to go out ASAP, or can it wait until the next FusionAuth release? I don't typically release a new chart version for minor changes like this. |
|
@johnjeffers I need this change as a requirement for the work we need to do to get listed to the Google Market Place. It could be done another way, but it would require the duplication of quite a bit of work. This should have full backwards compatibility and only introduces new functionality. if it is a huge problem, let me know. |
|
@johnjeffers If you are good with this, can you please approve? I'd really like to get this out. |
johnjeffers
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability add create labels for a pod. This is required for listing in the Google Marketplace. I updated the documentation as well. I believe we need to merge this to main and then create the tag, correct?