Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS CloudFront redirect to URL example. #3027

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mrudatsprint
Copy link
Contributor

This example documents how to use a AWS CloudFront Function to redirect to country-specific URLs, such as a FusionAuth instance.

@mrudatsprint mrudatsprint requested a review from mooreds April 24, 2024 21:36
@mrudatsprint
Copy link
Contributor Author

I'll take a look at the example_app_check error.

@mooreds
Copy link
Contributor

mooreds commented Apr 24, 2024

Don't worry about the example app check error, it's just because this isn't merged yet.

@mooreds
Copy link
Contributor

mooreds commented Apr 24, 2024

However, please update https://github.com/FusionAuth/fusionauth-example-cloudfront-redirect/blob/main/aws/cloudfront/cloudfunction/function.js to not have our URLs in it. Please put in sample URLs.

Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrudatsprint
Copy link
Contributor Author

However, please update https://github.com/FusionAuth/fusionauth-example-cloudfront-redirect/blob/main/aws/cloudfront/cloudfunction/function.js to not have our URLs in it. Please put in sample URLs.

I replaced the live FusionAuth URLs with sample URLs.

Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@mrudatsprint mrudatsprint merged commit d29d0a7 into master Apr 25, 2024
3 of 4 checks passed
@mrudatsprint mrudatsprint deleted the mrudat/cloudfront-redirect branch April 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants