Correct email configuration field name #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything else in `emailConfiguration` appears to be correct
lyleschemmerling
requested changes
Oct 16, 2024
2 different classes. The field in |
|
Correct. That component works for both cases. Odds are it is not getting passed the "is_tenant" prop on the tenant side |
lyleschemmerling
approved these changes
Oct 16, 2024
lyleschemmerling
approved these changes
Oct 16, 2024
johnjeffers
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything else in
emailConfigurationappears to be correct.The reason the check api test did not pick this up is it's correct in the sample requests/responses, but not the actual
<APIField>.