Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in missing claims to api doc and examples for external JWT Identity Provider #3429

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mooreds
Copy link
Contributor

@mooreds mooreds commented Dec 17, 2024

This is a fix for FusionAuth/fusionauth-issues#2070

There were some misordered api doc in the request and missing response parameters.

Was unsure about whether the oauth2.clientAuthenticationMethod should be documented.

@mooreds mooreds requested review from a team as code owners December 17, 2024 03:48
@mooreds mooreds changed the title Added in missing claims to api doc and examples Added in missing claims to api doc and examples for external JWT Identity Provider Dec 17, 2024
@mooreds mooreds requested review from wied03 and spwitt and removed request for wied03 December 17, 2024 19:21
Copy link
Contributor

@spwitt spwitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

clientAuthenticationMethod has a default value in our domain objects. It is also set (and returned) for external JWT IdPs despite not being used by that type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants