Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth token storage recommendations #3481

Merged
merged 27 commits into from
Feb 3, 2025

Conversation

mooreds
Copy link
Contributor

@mooreds mooreds commented Jan 24, 2025

No description provided.

@mooreds mooreds requested review from a team as code owners January 24, 2025 23:07
Copy link
Contributor

@alex-fusionauth alex-fusionauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly update further?

astro/src/content/articles/oauth/oauth-token-storage.mdx Outdated Show resolved Hide resolved
@mooreds
Copy link
Contributor Author

mooreds commented Jan 27, 2025

Thanks @alex-fusionauth . I added the additional column and a new mobile specific row.

@alex-fusionauth
Copy link
Contributor

@mooreds lgtm!

@mooreds mooreds requested review from spwitt and removed request for andrewpai and alex-fusionauth January 29, 2025 17:03
@mooreds mooreds requested a review from jobannon January 29, 2025 17:03
Copy link
Contributor

@spwitt spwitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend defining DPoP, BFF, and MTLS in a few places. I was not familiar with these terms.

If you have the bandwidth, it may be worth updating uses of server side to server-side where it is used as an adjective (e.g. "server-side request" and "server-side code").

@mooreds mooreds requested a review from spwitt January 29, 2025 19:46
spwitt
spwitt previously approved these changes Jan 29, 2025
jobannon
jobannon previously approved these changes Jan 30, 2025
Copy link
Contributor

@jobannon jobannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@mooreds mooreds dismissed stale reviews from jobannon and spwitt via 074bf35 January 30, 2025 18:04
@mooreds mooreds requested a review from jobannon January 30, 2025 18:28
Copy link
Contributor

@jobannon jobannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style choices. Looks good!

@mooreds mooreds merged commit d11dc28 into main Feb 3, 2025
3 checks passed
@mooreds mooreds deleted the mooreds/update-oauth-storage-recommendations branch February 3, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants