Enable repository in Drone when writing configuration #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the purpose of the key clearer to the user.
No need for prep commands to be a method. Making it a tuple makes it immutable.
- Names: camelCase to snake_case for all function, argument, and variable names. - Prefix functions with the name/type of the service they relate to: e.g., gin_ensure_token and drone_ensure_secrets. - Horizontal function signatures (instead of vertically stacking args). - Removed small one-use functions that were creating single-key dictionaries and replaced with literals. - Renamed annexFiles to input_files and backPushFiles to output_files - Cleared out some catch-all exception handling that seemed unnecessary. This needs more work since there's a lot of catch-all exception blocks that need revising. See issue #54.
The ensure_config function checks if an existing drone configuration exists, reads it in, checks if the existing lines match the template, and updates it, fixing mismatched template sections. This is all unnecessary since overwriting any existing file will have the same effect and is much simpler. I'm keeping the function around to use it for reading the existing config, validating it, and loading the values into the form for modification (future feature).
The user enabling the repository may not be the owner so the repository
path is not necessarily {user}/{reponame}.
Order Dockerfile steps from slowest to fastest and from least-frequently rebuilt to most. Front-end installation takes the longest. Back-end doesn't require building so it can be last.
Would cause exceptions when the user data request failed, which happened every time the login screen was loaded with an invalid token.
Method routing is limited by the decorator
mpsonntag
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a drone configuration in the service now enables the repository in Drone, which in turn creates the hook on GIN for triggering builds when the repository receives a push.
Other changes: