-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/irregular_structure_and_operations #536
Conversation
…ading from dataframe can now be done as a class method
…rid with NaNs in the unasigned values
… Function plot_and_scatter removed as it can be replicated by using the marker argument
…ality of as_frame and return_X_y arguments
…gularCoordinateIterator for the FDataIrregular class
…th composite slices
…h right operations is WIP
…points) as start_index for empty sample
…egoudout/scikit-fda-irregular into feature/irregular_operations
Automatic casting to float dtype is removed, as it prevents using different float sizes (or even integers in the future).
`FDataIrregular` personal proposed reviews
|
||
import itertools | ||
import numbers | ||
from typing import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F401 'typing.Callable' imported but unused
GridPointsLike, | ||
LabelTupleLike, | ||
) | ||
from ..typing._numpy import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F401 '..typing._numpy.DTypeLike' imported but unused
dtype=None, | ||
out=None, | ||
*, | ||
value_empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
C816 missing trailing comma in Python 3.6+
*, | ||
value_empty | ||
): | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
D401 First line should be in imperative mood
good_idx = tuple(good_idx) | ||
|
||
reduceat_out = ufunc.reduceat( | ||
array, indices[good_axis_idx], axis=axis, dtype=dtype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
C812 missing trailing comma
|
||
sample_idx = ( | ||
np.searchsorted( | ||
self.start_indices, np.arange(len(self.points)), "right" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
C812 missing trailing comma
|
||
if domain_range is None: | ||
sample_range = _get_sample_range_from_data( | ||
self.start_indices, self.points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
C812 missing trailing comma
try: | ||
from numpy.typing import ArrayLike as ArrayLike # noqa: WPS113 | ||
try: # noqa: WPS113 | ||
from numpy.typing import ArrayLike as ArrayLike, DTypeLike as DTypeLike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
WPS113 Found same alias import: ArrayLike
try: | ||
from numpy.typing import ArrayLike as ArrayLike # noqa: WPS113 | ||
try: # noqa: WPS113 | ||
from numpy.typing import ArrayLike as ArrayLike, DTypeLike as DTypeLike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
WPS113 Found same alias import: DTypeLike
except ImportError: | ||
ArrayLike = np.ndarray # type:ignore[misc] # noqa: WPS440 | ||
DTypeLike = np.dtype # type:ignore[misc] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
WPS440 Found block variables overlap: DTypeLike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the recent changes from PR #593, this is now ready to go,
Full functionality of FDataIrregular structure and operations. Includes: