Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SciPy 1.14. #630

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Support SciPy 1.14. #630

merged 1 commit into from
Aug 17, 2024

Conversation

vnmabus
Copy link
Member

@vnmabus vnmabus commented Aug 17, 2024

Describe the proposed changes

Fixed the code that was failing in the tests for Scipy 1.14:

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code conforms to the style used in this package
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

Fixed the code that was failing in the tests for Scipy 1.14:
- Calls to simpson with more than one positional parameters are invalid
(scipy/scipy#20554).
- Representation of SciPy sparse matrix in doctests has changed
(scipy/scipy#20649).
  - As this change makes tests fail for previous SciPy versions, the
minimum version of SciPy used for tests has been set to 1.14.
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (da69655) to head (22e4618).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #630   +/-   ##
========================================
  Coverage    86.83%   86.83%           
========================================
  Files          157      157           
  Lines        13522    13522           
========================================
  Hits         11742    11742           
  Misses        1780     1780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnmabus vnmabus merged commit 2f1fb20 into develop Aug 17, 2024
17 checks passed
@vnmabus vnmabus deleted the feature/support_scipy_1_14 branch August 31, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant