Ensure service remains healthy with rare messages. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rngcntr
requested review from
FlorianHockmann,
svkeller,
pkemkes,
lisa0930 and
LarsSchlieper
rngcntr
force-pushed
the
issue-973
branch
2 times, most recently
from
06ff605 to
c7aaa00
Compare
Fixes #973 If the queue is empty and the `MessageProcessingHealthCheck` is executed, the service resets the health check's timeout. For this to work, the health check frequency should be less than the MaxTimeSinceLastProcessedMessage.
pkemkes
approved these changes
Nov 14, 2023
| @@ -20,6 +20,7 @@ public BackgroundTaskQueue(IMetricsFactory<BackgroundTaskQueue<T>>? metricsFacto | |||
| _elementsInQueue = metricsFactory?.CreateGauge("task_queue_enqueued_elements", "", false, "type") | |||
| ?.WithLabels(typeof(T).Name); | |||
| _totalMessages = metricsFactory?.CreateCounter("total_messages", "", false, "type")?.WithLabels(typeof(T).Name); | |||
| LastDequeuedAt = DateTimeOffset.UtcNow; | |||
There was a problem hiding this comment.
nit: I'd prefer to rather have this as the default value in line 59 instead of here as a new line in the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
If the queue is empty and the
MessageProcessingHealthCheckis executed, the service resets the health check's timeout. For this to work, the health check frequency should be less than theMaxTimeSinceLastProcessedMessage.