refactor: 스터디상세 정적 팩토리 이름 변경

GDSC-Hongik · Oct 15, 2024 · eee5c51 · eee5c51
1 parent 3f0edc1
commit eee5c51
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/main/java/com/gdschongik/gdsc/domain/study/domain/StudyDetail.java b/src/main/java/com/gdschongik/gdsc/domain/study/domain/StudyDetail.java
@@ -71,7 +71,7 @@ private StudyDetail(
         this.assignment = assignment;
     }
 
-    public static StudyDetail createStudyDetail(Study study, Long week, String attendanceNumber, Period period) {
+    public static StudyDetail create(Study study, Long week, String attendanceNumber, Period period) {
         return StudyDetail.builder()
                 .study(study)
                 .week(week)

diff --git a/src/main/java/com/gdschongik/gdsc/domain/study/factory/StudyDomainFactory.java b/src/main/java/com/gdschongik/gdsc/domain/study/factory/StudyDomainFactory.java
@@ -40,6 +40,6 @@ public StudyDetail createNoneStudyDetail(Study study, Long week) {
 
         String attendanceNumber =
                 new Random().ints(4, 0, 10).mapToObj(String::valueOf).reduce("", String::concat);
-        return StudyDetail.createStudyDetail(study, week, attendanceNumber, Period.of(startDate, endDate));
+        return StudyDetail.create(study, week, attendanceNumber, Period.of(startDate, endDate));
     }
 }
diff --git a/src/test/java/com/gdschongik/gdsc/helper/FixtureHelper.java b/src/test/java/com/gdschongik/gdsc/helper/FixtureHelper.java
@@ -103,13 +103,12 @@ public Study createStudyWithMentor(Long mentorId, Period period, Period applicat
     }
 
     public StudyDetail createStudyDetail(Study study, LocalDateTime startDate, LocalDateTime endDate) {
-        return StudyDetail.createStudyDetail(study, 1L, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
+        return StudyDetail.create(study, 1L, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
     }
 
     public StudyDetail createNewStudyDetail(
             Long id, Study study, Long week, LocalDateTime startDate, LocalDateTime endDate) {
-        StudyDetail studyDetail =
-                StudyDetail.createStudyDetail(study, week, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
+        StudyDetail studyDetail = StudyDetail.create(study, week, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
         ReflectionTestUtils.setField(studyDetail, "id", id);
         return studyDetail;
     }

diff --git a/src/test/java/com/gdschongik/gdsc/helper/IntegrationTest.java b/src/test/java/com/gdschongik/gdsc/helper/IntegrationTest.java
@@ -263,14 +263,12 @@ protected Study createNewStudy(Member mentor, Long totalWeek, Period period, Per
     }
 
     protected StudyDetail createStudyDetail(Study study, LocalDateTime startDate, LocalDateTime endDate) {
-        StudyDetail studyDetail =
-                StudyDetail.createStudyDetail(study, 1L, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
+        StudyDetail studyDetail = StudyDetail.create(study, 1L, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
         return studyDetailRepository.save(studyDetail);
     }
 
     protected StudyDetail createNewStudyDetail(Long week, Study study, LocalDateTime startDate, LocalDateTime endDate) {
-        StudyDetail studyDetail =
-                StudyDetail.createStudyDetail(study, week, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
+        StudyDetail studyDetail = StudyDetail.create(study, week, ATTENDANCE_NUMBER, Period.of(startDate, endDate));
         return studyDetailRepository.save(studyDetail);
     }