round 전체 완성 #13
Open
round 전체 완성 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
round 부분 전체 완성(Round, RoundThumbnail 일부 추가, RoundThumbnailDTO, RoundController, RoundRepository, RoundThumbnailRepository, RoundService 추가)
cmj7271
reviewed
Jan 24, 2025
| @Operation(summary = "회차 생성", description = "새로운 회차를 생성합니다.") | ||
| public ResponseEntity<RoundDTO> createRound( | ||
| @Parameter(description = "스터디 ID", required = true) @PathVariable Long studyId, | ||
| @RequestParam String goal, |
There was a problem hiding this comment.
묶어서 requestDTO 하나 만드는게 좋아보여요
| public ResponseEntity<RoundDTO> updateRound( | ||
| @Parameter(description = "스터디 ID", required = true) @PathVariable Long studyId, | ||
| @Parameter(description = "회차 ID", required = true) @PathVariable Long roundId, | ||
| @RequestParam String goal, |
| import java.time.LocalDate; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| @Entity | ||
| @Getter | ||
| @NoArgsConstructor |
There was a problem hiding this comment.
다른 분들이랑 통일해서 noarg 는 protected로,
allarg 는 private으로 만들고,
builder annotation 은 클래스 위로 옮기는게 어떨까요
|
|
||
| @Entity | ||
| @Getter | ||
| @NoArgsConstructor |
There was a problem hiding this comment.
여기도 위처럼 noarg, allarg, builder 같은 이야기입니다
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| @Transactional |
There was a problem hiding this comment.
readOnly 로 바꿔주세요
자세한 내용은 디스코드에 적혀있어요
CreateRoundRequest, UpdateRoundRequest 생성 컨트롤러, 도메인, dto, service 일부 수정 @operation(summary = "회차 생성", description = "새로운 회차를 생성합니다.") public ResponseEntity<RoundDTO> createRound( @parameter(description = "스터디 ID", required = true) @PathVariable Long studyId, @RequestParam String goal, Member 묶어서 requestDTO 하나 만드는게 좋아보여요 src/main/java/com/gdgoc/study_group/round/controller/RoundController.java public ResponseEntity<RoundDTO> updateRound( @parameter(description = "스터디 ID", required = true) @PathVariable Long studyId, @parameter(description = "회차 ID", required = true) @PathVariable Long roundId, @RequestParam String goal, Member 여기도 묶어서 DTO로 바꾸는게 좋아보여요 @entity @Getter @NoArgsConstructor Member 다른 분들이랑 통일해서 noarg 는 protected로, allarg 는 private으로 만들고, builder annotation 은 클래스 위로 옮기는게 어떨까요 @entity @Getter @NoArgsConstructor Member 여기도 위처럼 noarg, allarg, builder 같은 이야기입니다 @service @requiredargsconstructor @transactional Member@cmj7271 readOnly 로 바꿔주세요 자세한 내용은 디스코드에 적혀있어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
round 부분 전체 완성(Round, RoundThumbnail 일부 추가, RoundThumbnailDTO, RoundController, RoundRepository, RoundThumbnailRepository, RoundService 추가)