Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 수강신청 페이지 & 내 과제 페이지 마크업 #24
[Feat] 수강신청 페이지 & 내 과제 페이지 마크업 #24
Changes from 9 commits
f30f653
b177f7a
a4f80f8
a5104aa
ceb687f
3f72228
a34a1fd
60d925f
9e26579
3de5f76
ebe1afe
df1c0cc
c521329
2206b40
d399093
4552b4b
2b1f937
e0de5c1
ff73c8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p4;
Box 컴포넌트가 props를 받을 때 children 방식이 아니라 text로 받고 있어서 어색한 거 같다는 생각이 들긴 하네요...
그래서 불필요한 wrapper 태그 (Fragment)를 추가해줘야 하는 거 같습니다...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음음 Box 에 들어가는 내용들이 점점 많아지면서
text
보다 children 으로 받는 게 더 맞는 거 같은.. 생각이 드네요. 요것도 컴파운드 패턴으로 수정해주면 코드의 가독성이 개션될 것 같아요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 머지하고 추후 태스크로 개선해보면 좋을 거 같긴 합니다!
Box 컴포넌트 개발해주신 유진님은 어떻게 생각하시나요?
@eugene028