Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Tab 컴포넌트 구현 #162

Merged
merged 17 commits into from
Oct 12, 2024
Merged

[Feature] Tab 컴포넌트 구현 #162

merged 17 commits into from
Oct 12, 2024

Conversation

SeieunYoo
Copy link
Collaborator

@SeieunYoo SeieunYoo commented Sep 11, 2024 •
edited
Loading

🎉 변경 사항

image

  • Tab 컴포넌트를 구현합니다.
  • 컴포넌트 내부에서 추가하는 ref와 외부에서 주입한 ref 를 모두 관리해주기 위해 useMergeRefs 훅을 추가합니다.
  • style, classname 과 같은 props 는 컴포넌트에서 공통으로 들어가고 있어서 DefaultProps 라는 타입을 추가합니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

  • Tab 이 길어졌을 때 UI 관련하여 질문 피그마에 남겨놨는데 디자이너분께서 코멘트 남겨주시면 반영할 예정입니다~ -> 반영완료

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-dqpjllqlcl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-xmaahebbax.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-vglnqtkhoc.chromatic.com/

ghdtjgus76
ghdtjgus76 reviewed Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

packages/wow-ui/src/components/Tabs/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tabs/TabsTrigger.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tabs/TabsList.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tabs/TabsTrigger.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tabs/Tabs.test.tsx Outdated Show resolved Hide resolved
hamo-o
hamo-o reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!! 탭을 등록하는 부분 때문에 다른 디자인 시스템 코드가 생각보다 엄청 복잡해서 놀랐네요 🫥

packages/wow-ui/src/components/Tabs/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/types/DefaultProps.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tabs/TabsTrigger.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Tabs/index.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-eqtgzesdcl.chromatic.com/

@SeieunYoo SeieunYoo requested review from ghdtjgus76 and hamo-o October 9, 2024 18:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-mfdfpcdufo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-zjskafejup.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~

packages/wow-ui/src/components/Tabs/TabsTrigger.tsx Outdated Show resolved Hide resolved
hamo-o
hamo-o approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당

@SeieunYoo SeieunYoo merged commit 7b19f05 into main Oct 12, 2024
3 checks passed
@SeieunYoo SeieunYoo deleted the feat/tab-component branch October 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamo-o hamo-o hamo-o approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 Awaiting requested review from eugene028 eugene028 is a code owner

Assignees

@SeieunYoo SeieunYoo

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Tab 컴포넌트 구현
3 participants
@SeieunYoo @ghdtjgus76 @hamo-o