Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Divider 컴포넌트 구현 #49

Merged
merged 8 commits into from
Jul 24, 2024
Merged

[Feature] Divider 컴포넌트 구현 #49

merged 8 commits into from
Jul 24, 2024

Conversation

kongnayeon
Copy link
Member

@kongnayeon kongnayeon commented Jun 9, 2024 •
edited by ghdtjgus76
Loading

🎉 변경 사항

스크린샷 2024-06-09 오후 8 07 42

디바이더 컴포넌트를 구현했습니다.
디바이더는 따로 테스트할 게 없다고 생각되어 스토리 파일만 작성했는데, 테스트 코드가 따로 필요하다고 논의되면 추가하도록 하겠습니다!!
늦어져서 죄송합니다. . . 😓

🚩 관련 이슈

@kongnayeon kongnayeon self-assigned this Jun 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-rjticygiad.chromatic.com/

hamo-o
hamo-o reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~!

packages/wow-ui/src/components/Divider/index.tsx Outdated Show resolved Hide resolved
ghdtjgus76
ghdtjgus76 reviewed Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 수고하셨어요~

packages/wow-ui/src/components/Divider/Divider.stories.ts Show resolved Hide resolved
packages/wow-ui/src/components/Divider/Divider.stories.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Divider/Divider.stories.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Divider/index.tsx Outdated Show resolved Hide resolved
SeieunYoo
SeieunYoo reviewed Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니당~~🙌

packages/wow-ui/src/components/Divider/index.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-azcpcpzrpg.chromatic.com/

@hamo-o hamo-o requested review from SeieunYoo and ghdtjgus76 July 23, 2024 03:38
ghdtjgus76
ghdtjgus76 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 수고하셨습니다~

SeieunYoo
SeieunYoo approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요 수고 많으셨습니당!!

@kongnayeon
Copy link
Member Author

수정 감사합니다 🥺🥺 고생하셨어욥 🥺🥺...

@hamo-o hamo-o merged commit 7f127b0 into main Jul 24, 2024
3 checks passed
@hamo-o hamo-o deleted the feature/divider-component branch July 24, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamo-o hamo-o hamo-o left review comments

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 Awaiting requested review from eugene028 eugene028 is a code owner

Assignees

@kongnayeon kongnayeon

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kongnayeon @ghdtjgus76 @hamo-o @SeieunYoo