Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style/#166: 공지사항 페이지 디자인 개선 #191

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Style/#166: 공지사항 페이지 디자인 개선 #191

merged 3 commits into from
Aug 29, 2023

Conversation

hwinkr
Copy link
Collaborator

@hwinkr hwinkr commented Aug 26, 2023

🤠 개요

💫 설명

  • 공지사항 제목이 1줄만 나오도록 설정하고, 모바일 기준 font-sizer가 너무 큰 것 같아서 조금 줄였어요
  • 슬라이드 애니메이션을 적용하긴 했는데 데스크탑 환경에서는 화면 영역을 벗어난곳에서 애니메이션이 시작되어서 이상하지만, 모바일 환경에서는 괜찮은 것 같아요
  • 고정이 아닌 일반 공지사항도 고정아이콘 speaker만큼 margin-left를 두긴 했는데 이상하면 화면 제일 왼쪽에 붙여버려도 괜찮을 것 같아요

📷 스크린샷 (Optional)

default.mov

@hwinkr hwinkr self-assigned this Aug 26, 2023
pp449
pp449 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 확실히 보기 편해진거 같아요

@hwinkr hwinkr merged commit 2a2f328 into dev Aug 29, 2023
1 check passed
@hwinkr hwinkr deleted the style/#166 branch August 29, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@hwinkr hwinkr

Labels
💇‍♂️ style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style: 공지사항 페이지 디자인 개선
2 participants
@hwinkr @pp449