Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[팀 C - 이지정] 1차 코드 리뷰 요청 #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

o-jeong
Copy link

@o-jeong o-jeong commented Nov 26, 2023

No description provided.

@surplus-dev
Copy link

surplus-dev commented Nov 26, 2023

image
더불어서 이 부분이 len이면 더 나을 것 같습니다

그리고 class 기반으로 바꾸면 전역 변수 참조 안해도 되니 더 좋을 것 같습니다

나머지는 깔끔하게 잘 분리된 것 같습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants