Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/numeric to word #360

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bugfix/numeric to word #360

wants to merge 5 commits into from

Conversation

SamuelCahyawijaya
Copy link
Contributor

  • Change isnumeric() to isdigit()
  • Handle unhandled cases in some number transformations

@SamuelCahyawijaya
Copy link
Contributor Author

I think the error is caused by ChangeDateFormat transformation which is not related to our changes whatsoever. How could we go through this problem? Please advice 👍🏻

@AbinayaM02
Copy link
Collaborator

I think the error is caused by ChangeDateFormat transformation which is not related to our changes whatsoever. How could we go through this problem? Please advice 👍🏻

Hi @SamuelCahyawijaya: The error with ChangeDateFormat is fixed a while ago. The current error is because of a mismatch in numeric_to_word transformation only. Please pull the latest code and fix the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamuelCahyawijaya @AbinayaM02