Skip to content

Commit

Permalink
replace z-index with isolate
Browse files Browse the repository at this point in the history
  • Loading branch information
RobAndrewHurst committed Oct 29, 2024
1 parent 9294264 commit b43b85b
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 17 deletions.
14 changes: 7 additions & 7 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,39 +16,39 @@ The executables `git` and `node` should be in your `PATH`.

To install the Node.js dependencies run

$ npm install
npm install

Please check the full list of dependencies as defined in the [package.json](https://github.com/GEOLYTIX/xyz/blob/main/package.json)

## ESBuild

The MAPP and MAPP.UI library must be build with [esbuild](https://esbuild.github.io/) prior to launching the host.

$ npx esbuild ./lib/mapp.mjs ./lib/ui.mjs --bundle --minify --tree-shaking=false --sourcemap --format=iife --outdir=./public/js/lib
npx esbuild ./lib/mapp.mjs ./lib/ui.mjs --bundle --minify --tree-shaking=false --sourcemap --format=iife --outdir=./public/js/lib

The build command is stored in the package.json as `_build` script.

$ npm run _build
npm run _build

ESBuild must also be used to compile the CSS supporting the MAPP and MAPP.UI elements.

$ npx esbuild --bundle public/css/_mapp.css --outfile=public/css/mapp.css
npx esbuild --bundle public/css/_mapp.css --outfile=public/css/mapp.css

$ npx esbuild --bundle public/css/_ui.css --outfile=public/css/ui.css --loader:.svg=dataurl
npx esbuild --bundle public/css/_ui.css --outfile=public/css/ui.css --loader:.svg=dataurl

## version.js hash

The mapp module object holds a hash of the latest release commit which can be generated by executing the version.js script in the root.

The version script will complete by executing the ESBuild process.

$ node version.js
node version.js

## Express

[Express.js](https://expressjs.com/) will be installed by npm as a development dependency. You can run a zero config instance by loading the express.js script in your node runtime.

$ node express.js
node express.js

The default port is 3000. You can access the mapp interface on <http://localhost:3000/> in your browser.

Expand Down
2 changes: 1 addition & 1 deletion public/css/_dialog.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dialog.dialog {
user-select: none;
padding: 5px;
overflow: unset !important;
z-index: 5;
isolation: isolate;
}

dialog.modal {
Expand Down
17 changes: 9 additions & 8 deletions public/css/_inputs.css
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ input[type=search]+ul:active {

input[type="search"]::-webkit-search-cancel-button,
input[type="search"]::-webkit-search-decoration:hover,
input[type="search"]::-webkit-search-cancel-button:hover {
cursor:pointer;
input[type="search"]::-webkit-search-cancel-button:hover {
cursor: pointer;
}

label.checkbox {
Expand Down Expand Up @@ -243,9 +243,10 @@ label.checkbox {

&>.head>.icon {
content: url("../icons/icon-drop-up.svg");
}
}
}
&.dropdown-reverse > ul {

&.dropdown-reverse>ul {
bottom: 30px;
}
}
Expand Down Expand Up @@ -291,13 +292,13 @@ label.checkbox {
z-index: 2;
width: calc((var(--a) - var(--min)) / var(--dif) * (100% - 10px));
}

&.multi {
& >.label-row {
&>.label-row {
display: flex;
justify-content: space-between;

& >div {
&>div {
flex-grow: 1
}
}
Expand Down Expand Up @@ -384,4 +385,4 @@ label.checkbox {
background-repeat: no-repeat;
background-position: center;
box-shadow: none;
}
}
2 changes: 1 addition & 1 deletion public/css/ui.css
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ dialog.dialog {
user-select: none;
padding: 5px;
overflow: unset !important;
z-index: 5;
isolation: isolate;
}
dialog.modal {
position: fixed;
Expand Down

0 comments on commit b43b85b

Please sign in to comment.