Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer display toggle button has no layer identifier. #1629

Closed
cityremade opened this issue Oct 30, 2024 · 1 comment · Fixed by #1633
Closed

Layer display toggle button has no layer identifier. #1629

cityremade opened this issue Oct 30, 2024 · 1 comment · Fixed by #1633
Assignees
Labels
Code Issues related to the code structure and performance.

Comments

@cityremade
Copy link
Member

cityremade commented Oct 30, 2024

At the moment for analytics needs we cannot tell which layer is the parent of each display toggle without an acrobatic selector.

To add a data attribute to hold layer key apart from only data-id=display-toggle for each element.

It would make it clear which layer was toggled.

I don't mind adding it to .header. Way better than 3rd parent.

@cityremade cityremade added the Code Issues related to the code structure and performance. label Oct 30, 2024
@dbauszus-glx
Copy link
Member

Yeah. The assignment of layer-drawer as data-id is bad. Let me fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants