Remove data-id assignment for layer-view element #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
Code
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
|
AlexanderGeere
approved these changes
Oct 31, 2024
cityremade
approved these changes
Oct 31, 2024
RobAndrewHurst
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A data-id is not a class!
A data-id is a pseudo id as the nomination suggests.
The data-id for a layer view/drawer element should be the layer.key.
The data-id for a [layer] group view/drawer should be the group id.
There should not be a queryselector for
data-id=layer-drawerwhich is better solved with a combo class eg..layer-view.drawer