Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom Toggle Fix #1011

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Zoom Toggle Fix #1011

merged 1 commit into from
Nov 20, 2023

Conversation

simon-leech
Copy link
Contributor

Steps to reproduce the bug prior to this PR:

  1. Click zoom to button on a zoom restricted layer
  2. Click zoom to button again (zooms you out and turns layer 'off')
  3. Zoom in using box zoom
  4. Layer appears but toggle isn't orange

This was due to missing setting the layer to display false when the zoom to button was pressed twice

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dbauszus-glx
dbauszus-glx approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@RobAndrewHurst RobAndrewHurst marked this pull request as ready for review November 20, 2023 10:50
@RobAndrewHurst RobAndrewHurst merged commit 4cdeddf into GEOLYTIX:main Nov 20, 2023
6 checks passed
@simon-leech simon-leech deleted the zoom-toggle branch February 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbauszus-glx dbauszus-glx dbauszus-glx approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@RobAndrewHurst RobAndrewHurst Awaiting requested review from RobAndrewHurst

@eo-uk eo-uk Awaiting requested review from eo-uk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-leech @dbauszus-glx @RobAndrewHurst