DBS initialisation and timeouts #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
Bug
dbauszus-glx
requested review from
RobAndrewHurst,
cityremade,
simon-leech and
eo-uk
|
Kudos, SonarCloud Quality Gate passed!
|
RobAndrewHurst
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dbs object shouldn't be created on each require but only once when the process initiates with only the dbs object exported from the module.
The dbs should only be required without executing the exported method.
The statement_timeout does nothing on the pool. Setting the statement_timeout environment variable will set the statement prior to the query.
The statement_timeout doesn't have to be reset since the client is released after the query.
Only one pool should be created for the acl connection and stored outside the closure which returns the async query. The method should release the client after each query.