Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error for 4326 mvt layer #1023

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Add error for 4326 mvt layer #1023

merged 2 commits into from
Dec 4, 2023

Conversation

simon-leech
Copy link
Contributor

Adding a check on srid and returning an error if its 4326 as no longer supported.

@simon-leech simon-leech marked this pull request as ready for review December 1, 2023 10:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dbauszus-glx
dbauszus-glx approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to warning since there is no actual error exception. I also moved the default assignment and check on srid not '3857' rather than is '4326'. Other projections would also fail.

@RobAndrewHurst RobAndrewHurst merged commit 8f74838 into GEOLYTIX:main Dec 4, 2023
6 checks passed
@simon-leech simon-leech deleted the mvt-error branch February 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbauszus-glx dbauszus-glx dbauszus-glx approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@RobAndrewHurst RobAndrewHurst Awaiting requested review from RobAndrewHurst

@eo-uk eo-uk Awaiting requested review from eo-uk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-leech @dbauszus-glx @RobAndrewHurst