Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations #1047

Merged
merged 15 commits into from
Jan 23, 2024
Merged

Translations #1047

merged 15 commits into from
Jan 23, 2024

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Dec 21, 2023 •
edited
Loading

  1. Been through the XYZ Framework and converted any english text strings into dictionary entries so we can update the translations.
  2. Updated the admin panel to allow administrators to change the language. This works on a lookup object so we store en or de to the database, but the user will see English or German

@simon-leech simon-leech requested review from dbauszus-glx, RobAndrewHurst, cityremade and eo-uk and removed request for dbauszus-glx December 21, 2023 13:43
@simon-leech simon-leech marked this pull request as ready for review December 21, 2023 13:43
RobAndrewHurst
RobAndrewHurst approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

When do we plan to add other languages to these translations?

@simon-leech
Copy link
Contributor Author

https://docs.google.com/spreadsheets/d/1Rqf0wR7Tm8-yxDTUjct2iDK5dpnasYXm_zkRNU3zeMw/edit#gid=0

@RobAndrewHurst I've set up this language translation sheet and we can crowd-source the translations from within the company - will ask people to fill in today.

Wonder if we merge this PR and then open another when the translations are ready?

@dbauszus-glx
Copy link
Member

Let me add the German translation now.

dbauszus-glx
dbauszus-glx approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@simon-leech
Copy link
Contributor Author

I've got all the translations now - so will convert this back to draft until i'm implemented it - then open it again for review :)

@simon-leech simon-leech marked this pull request as draft January 4, 2024 15:53
@simon-leech
Copy link
Contributor Author

This is now ready for review again.
All the language translations have been implemented and I've updated the html to provide the options for each language option.

@simon-leech simon-leech marked this pull request as ready for review January 15, 2024 15:09
RobAndrewHurst
RobAndrewHurst approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Looks all good!

@simon-leech
Copy link
Contributor Author

Just committed the Thai translations so we now have 11 supported languages -

  1. English
  2. German
  3. Spanish
  4. French
  5. Italian
  6. Turkish
  7. Chinese
  8. Chinese (Traditional)
  9. Thai
  10. Polish
  11. Japanese
    🎉🎉

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RobAndrewHurst RobAndrewHurst merged commit ea8fadd into GEOLYTIX:main Jan 23, 2024
5 checks passed
@simon-leech simon-leech deleted the translations branch February 9, 2024 11:08
@RobAndrewHurst RobAndrewHurst added the Feature New feature requests or changes to the behaviour or look of existing application features. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAndrewHurst RobAndrewHurst RobAndrewHurst approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@eo-uk eo-uk Awaiting requested review from eo-uk

@dbauszus-glx dbauszus-glx Awaiting requested review from dbauszus-glx

Assignees
No one assigned
Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-leech @dbauszus-glx @RobAndrewHurst