-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not from if to remove #1155
Remove not from if to remove #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A filter set as default should not be cleared.
Screencast.from.26-02-24.11.30.02.webm
The clear all filter text should not show when the filter drawer is collapsed.
@dbauszus-glx As of my most recent changes, the filter will now be reset to the filter that was present on load. This should correct the behaviour you observed while actually clearing the filter from the layer. |
There is still an issue flagged by the scan! Can you fix that @AlexanderGeere |
This works for me now. The Filter without a field are not attempted to be deleted. The zoom flag toggle has been removed as not required. Filter panel is unavailable outside zioom range. Filter is deleted when key array length is falsy. |
Quality Gate passedIssues Measures |
Clear all filters was just closing the filter panel, but had no effect on the layer.
This fix removes the filter and updates the layer accordingly.