Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create layer changend module. #1184

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Create layer changend module. #1184

merged 1 commit into from
Mar 14, 2024

Conversation

dbauszus-glx
Copy link
Member

The changeend should not be duplicated for mvt and vector layer but called from a mapp.layer module.

The changeend method should not sent multiple show / hide calls on changes within or outside the zoom range.

@dbauszus-glx dbauszus-glx added Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. labels Mar 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

cityremade
cityremade approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@cityremade cityremade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No longer redundant .show() run.

@dbauszus-glx dbauszus-glx merged commit 21057cc into GEOLYTIX:main Mar 14, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the layer-changeend branch June 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cityremade cityremade cityremade approved these changes

@AlexanderGeere AlexanderGeere Awaiting requested review from AlexanderGeere

@RobAndrewHurst RobAndrewHurst Awaiting requested review from RobAndrewHurst

@simon-leech simon-leech Awaiting requested review from simon-leech

Assignees
No one assigned
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbauszus-glx @cityremade