Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split plugins into modules; Add keyvalue_dictionary #1187

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

dbauszus-glx
Copy link
Member

I split the default plugins module into individual modules in the plugins directory and added the keyvalues_dictionary plugin.

@dbauszus-glx dbauszus-glx added the Code Issues related to the code structure and performance. label Mar 19, 2024
@RobAndrewHurst
Copy link
Contributor

This PR is dependent on #1186

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, documented and good to go!

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me!
The documentation looks good, plugins are all loading.
I tested keyvalue against a layer title, infoj entry tabulator column, layer meta and chartJS scale text and all were replaced! 👏👏

@dbauszus-glx dbauszus-glx merged commit b6389d2 into GEOLYTIX:main Mar 20, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the plugins-folder branch June 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants