Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codi 🐶 #1190

Merged
merged 12 commits into from
Mar 22, 2024
Merged

Codi 🐶 #1190

merged 12 commits into from
Mar 22, 2024

Conversation

RobAndrewHurst
Copy link
Contributor

@RobAndrewHurst RobAndrewHurst commented Mar 21, 2024

Welcome Codi! 🐶

I have replaced Jest with the lightweight test framework Codi.

Codi is a lightweight JavaScript test framework that allows you to write and run tests for your JavaScript code. It provides a simple and intuitive API for defining test suites and test cases, making it easy to ensure the correctness of your code. ✨

  1. You can refer to the README.md on the Codi package for the different assertions built into Codi.

  2. I have also included a new Roles test which will need to be updated in Role merge #1185.

To run the tests locally you will just need to execute npm test which will run codi against the tests directory.

@RobAndrewHurst
Copy link
Contributor Author

image

Codi working in actions

@RobAndrewHurst RobAndrewHurst added the Testing Changes relating to existing or new unit tests. label Mar 21, 2024
@RobAndrewHurst RobAndrewHurst changed the title Codi init tests Codi 🐶 Mar 21, 2024
@RobAndrewHurst
Copy link
Contributor Author

image

Works with failing tests.

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobAndrewHurst Think this is a Windows issue with Codi but can you take a look?
image

@RobAndrewHurst
Copy link
Contributor Author

RobAndrewHurst commented Mar 21, 2024

@RobAndrewHurst Think this is a Windows issue with Codi but can you take a look? image

This has now been fixed in codi v0.0.8

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobAndrewHurst Thanks all running for me now!

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I added merge.test.mjs which passed.

I only use assertDeepEqual. I think we can get rid of assertEqual in favour of always using the deepEqual logic.

image

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RobAndrewHurst RobAndrewHurst merged commit c7c0baf into GEOLYTIX:main Mar 22, 2024
5 checks passed
@RobAndrewHurst RobAndrewHurst deleted the codi branch March 22, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Changes relating to existing or new unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants