-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Selection of a Location on a Layer with no Infoj #1500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test for no infoj.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I only updated the wording and removed the location from layer.infoj property and made this optional in jsdocs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am all happy with this.
I added in a test for the getInfoj method so that people can better understand the purpose.
Prevent Selection of a Location on a Layer with no Infoj
Description
Currently, the
location/get
method does not check for the presence of aninfoj
on the locations layer.This means that its possible to select a location, which then errors as it tries to build a SQL statement in this format
SELECT id, FROM table WHERE id = $1
.This PR addresses this by simply returning if the layer has no infoj, preventing this issue.
Type of Change
Please delete options that are not relevant, and select all options that apply.
Testing Checklist
Please delete options that are not relevant, and select all options that apply.
Code Quality Checklist
Please delete options that are not relevant, and select all options that apply.