Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back & document cluster featureformat #1505

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

RobAndrewHurst
Copy link
Contributor

Description

This PR puts back what was thought to be an unused function on the featureFormats module.

I have added in a test for a vector layer that will be a 'cluster'.

I have also added in documentation on the function.

Let me know if there is anything else I could improve.

Type of Change

Please delete options that are not relevant, and select all options that apply.

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✅ Documentation
  • ✅ Testing

@RobAndrewHurst RobAndrewHurst added Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. v4.11.0 labels Sep 26, 2024
@simon-leech simon-leech self-requested a review September 26, 2024 16:19
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - tested with a cluster layer configuration and working - tests and docs look good 👏

@dbauszus-glx dbauszus-glx self-requested a review September 26, 2024 17:00
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review in progress; There's some documentation issues.

@dbauszus-glx dbauszus-glx self-requested a review September 26, 2024 17:23
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now for me. I changed layer param to layer typedef.

Copy link

@RobAndrewHurst RobAndrewHurst merged commit 852ede2 into GEOLYTIX:main Sep 27, 2024
5 checks passed
@RobAndrewHurst RobAndrewHurst deleted the featureformats_cluster branch September 27, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants