Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match Using =
Description
The
match
filter type was incorrectly using ILIKE, which is in fact case insensitive and thus not a simple match. ILIKE should be used for thelike
filter. = should be used for thematch
filter.ILIKE is slower as postgres indexes don't always use it, so match should use a simple
=
that is recognised and indexes are used for this.I have also updated the sqlFilter tests to test each filter type and assert on the expected filter built.
Type of Change
Please delete options that are not relevant, and select all options that apply.
Testing Checklist
Please delete options that are not relevant, and select all options that apply.
Code Quality Checklist
Please delete options that are not relevant, and select all options that apply.