Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate mbtiles format #1617

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

dbauszus-glx
Copy link
Member

The mbtiles format dependent on a legacy version of the maplibre library has now been removed.

@dbauszus-glx dbauszus-glx self-assigned this Oct 29, 2024
@dbauszus-glx dbauszus-glx added the Deprecated Features which are no longer supported and should eventually be removed. label Oct 29, 2024
@dbauszus-glx dbauszus-glx linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can StyleParser check for this layer format and warn (can it parse to the correct format)?
If you have an mbtiles layer on this PR, it just crashes without any helpful debugging or anything.

@dbauszus-glx
Copy link
Member Author

Can StyleParser check for this layer format and warn (can it parse to the correct format)? If you have an mbtiles layer on this PR, it just crashes without any helpful debugging or anything.

Not possible since the styleParser checks on vector styles only and mbtiles do not have a style object.

@dbauszus-glx
Copy link
Member Author

dbauszus-glx commented Oct 29, 2024

@simon-leech You can add a deprecation warning in lib/layer/format/_format.mjs

/**
@function mbtiles
@deprecated

@description
The mbtiles layer format method has been deprecated.
*/
function mbtiles() {

  console.warn(`The mbtiles layer format method has been deprecated.`)
}

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add a warning for mbtiles instead of just removing it just to prevent any crashes without any helpful debugging messages.

@dbauszus-glx dbauszus-glx merged commit aa8da41 into GEOLYTIX:main Oct 30, 2024
3 checks passed
Copy link

sonarqubecloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbauszus-glx dbauszus-glx deleted the deprecate-mbtiles-format branch November 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecated Features which are no longer supported and should eventually be removed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate mbtiles format; Add ol-mapbox-style;
2 participants