-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate mbtiles format #1617
deprecate mbtiles format #1617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can StyleParser check for this layer format and warn (can it parse to the correct format)?
If you have an mbtiles layer on this PR, it just crashes without any helpful debugging or anything.
Not possible since the styleParser checks on vector styles only and mbtiles do not have a style object. |
@simon-leech You can add a deprecation warning in lib/layer/format/_format.mjs /**
@function mbtiles
@deprecated
@description
The mbtiles layer format method has been deprecated.
*/
function mbtiles() {
console.warn(`The mbtiles layer format method has been deprecated.`)
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add a warning for mbtiles instead of just removing it just to prevent any crashes without any helpful debugging messages.
Quality Gate passedIssues Measures |
The mbtiles format dependent on a legacy version of the maplibre library has now been removed.