Drawing ui - circle settings in a dialog; #1625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome would invalidate datauri set as background-image on a div;
…range; Fixes an issue where user can manually enter invalid numbers;
…min/max range;" This reverts commit a8742ef.
|
An issue needs to be created or assigned to this pr |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Layer Drawing UI
Circle drawing current settings are displayed in a dialog when the button in the drawing panel is hit.
They can be changed or reused before drawing interaction starts - or can be cancelled.
Putting these settings within an expandable panel is not clear that anything important is nested there
so showing default/recent settings to the user is a possible solution to both accessibility and clear layout in the panel.
GitHub Issue
Provide the link to the relevant GitHub issue it addresses.
Type of Change
Please delete options that are not relevant, and select all options that apply.