Explain the WORKSPACE AGE in more detail #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
Closed
cityremade
approved these changes
Oct 30, 2024
AlexanderGeere
approved these changes
Oct 30, 2024
RobAndrewHurst
requested changes
Oct 31, 2024
|
@RobAndrewHurst I wouldn't know a recommended value. The workspace age is only required if a workspace is likely to change. By default the workspace doesn't change hence there is no default age. I don't want to set this to an hour, or a day and then expkain that this is just an example default not required which can be overwritten. |
RobAndrewHurst
approved these changes
Oct 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getTemplate and cacheWorkspace methods are now linked with an example and link to the query module why it is not recommended to set the WORKSPACE_AGE to 0.