Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OL to 10.3.1 to include clear cache fix. #1785

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

dbauszus-glx
Copy link
Member

This patch PR upgrades OL to 10.3.1 which includes a fix to clear the LRU cache properly.

openlayers/openlayers#16328

The workaround setting the OL source property manually has been removed. OL properties should never be directly modified but only through the OL api.

The associated test has been removed since it is meaningless. The test set a property to foo before calling a method which sets the property to an empty object and then checking whether the property is set to an empty object. The test did not actually look at the tile cache and associated trigger.

@dbauszus-glx dbauszus-glx self-assigned this Jan 2, 2025
@dbauszus-glx dbauszus-glx added Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Testing Changes relating to existing or new unit tests. labels Jan 2, 2025
Copy link

sonarqubecloud bot commented Jan 2, 2025

@dbauszus-glx dbauszus-glx linked an issue Jan 2, 2025 that may be closed by this pull request
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all as expected for me.

Copy link
Member

@cityremade cityremade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@simon-leech simon-leech merged commit 489405d into GEOLYTIX:patch Jan 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. Testing Changes relating to existing or new unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVT reload doesn't request tiles from source.
3 participants