Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide user roles param for admin requests. #1801

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

dbauszus-glx
Copy link
Member

This PR introduces the roles request parameter for admin user to test roles on any request, eg. checking layer access in a locale.

http://localhost:3000/api/workspace/locale?locale=test&layers=true&roles=foo,bar

@dbauszus-glx dbauszus-glx added Feature New feature requests or changes to the behaviour or look of existing application features. Testing Changes relating to existing or new unit tests. labels Jan 7, 2025
@dbauszus-glx dbauszus-glx self-assigned this Jan 7, 2025
@dbauszus-glx dbauszus-glx linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what we need - working as expected!

In v4.13.0 as part of this ongoing issue (#1778 (comment)) we can implement this into the integrity tests to enable us to return a list of layers / functionality by role! 🪄

Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobAndrewHurst RobAndrewHurst merged commit f5faa34 into GEOLYTIX:minor Jan 10, 2025
6 checks passed
@GEOLYTIX GEOLYTIX deleted a comment from gitguardian bot Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature requests or changes to the behaviour or look of existing application features. Testing Changes relating to existing or new unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override roles for admin user
3 participants