The temporal utility mod must not throw an error to take down infoj p… #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocess without return and parse integer values.
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
dbauszus-glx
added
the
Bug
|
RobAndrewHurst
approved these changes
Feb 3, 2025
simon-leech
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporal utility module should be able to handle null, undefined, or string values (including empty).
The integer value required for the Date generation should be parsed from entry value (or newValue).
An error should be logged instead of thrown with the method returning and not crashing the infoj process.