Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queryParams.mjs #962

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Update queryParams.mjs #962

merged 13 commits into from
Oct 13, 2023

Conversation

simon-leech
Copy link
Contributor

This PR is directly related to the fix in this one #960 . However, i omitted the check for if table: true is passed from a layer.dataview. This PR adds the check for this as well. So now table:true is supported whether the dataview comes from an entry or a layer.

@simon-leech simon-leech added the Bug A genuine bug. There must be some form of error exception to work with. label Oct 12, 2023
KieronFerrey
KieronFerrey previously approved these changes Oct 12, 2023
@simon-leech
Copy link
Contributor Author

simon-leech commented Oct 12, 2023

I have amended the code to check for the presence of table:true instead of just the presence of table. As it is valid to provide table as a string. e.g. table: "schema.table"

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever a case where the module could and should work without _this.queryparams being an object?

In that case the method should just return nothing.

e.g.

if (typeof _this.queryparams !== 'object') return;

@RobAndrewHurst RobAndrewHurst dismissed KieronFerrey’s stale review October 13, 2023 08:15

Needs to be re-reviewed because of additional changes.

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only changed to use const instead of let.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dbauszus-glx dbauszus-glx merged commit f37c0da into GEOLYTIX:main Oct 13, 2023
6 checks passed
@simon-leech simon-leech deleted the layer-queryparams-table branch February 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants