-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update queryParams.mjs #962
Update queryParams.mjs #962
Conversation
I have amended the code to check for the presence of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ever a case where the module could and should work without _this.queryparams being an object?
In that case the method should just return nothing.
e.g.
if (typeof _this.queryparams !== 'object') return;
Needs to be re-reviewed because of additional changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only changed to use const instead of let.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR is directly related to the fix in this one #960 . However, i omitted the check for if
table: true
is passed from alayer.dataview
. This PR adds the check for this as well. So nowtable:true
is supported whether the dataview comes from anentry
or alayer
.