assign null value in merge util. fire changeend event on start. #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
the
Bug
dbauszus-glx
requested review from
cityremade,
RobAndrewHurst,
simon-leech and
eo-uk
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I have noticed something where if you turn a layer on and then zoom past the allowed min zoom the layer will still render. Would the desired behaviour be that the canvas is cleared of that layer? |
|
@RobAndrewHurst That shouldn't happen. I will have a look to address the issue. |
|
@RobAndrewHurst should be fixed in last commit. |
|
Nice one! Thanks @dbauszus-glx |
|
Kudos, SonarCloud Quality Gate passed!
|
RobAndrewHurst
approved these changes
Oct 17, 2023
simon-leech
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge util incorrectly assigned an empty object instead of null.
The changeEnd event must be fired when the mapview is initialised. Otherwise the event would not be fired with no layer on display. The table check would be omitted in that case.