Encode Values returned from DB for filter panel #983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-leech
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an error.
If you use a filter config as shown below, and any of the data returned from the response containing special characters (% etc). The filter fails to create.
{ "field": "field", "title": "Title", "inline": true, "filter": { "type": "in", "distinct": true, "dropdown": true } }This PR simply encodes the value responses, and encodes and decodes the values for the dropdown module to remove this error.
Update - also addresses including special characters in the style and filtering there (ie Value % or Value &).
Also addresses including special characters in the layer.filter.