New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ID if field is undefined in theme. #987

Merged

dbauszus-glx merged 2 commits into GEOLYTIX:main from dbauszus-glx:distributed-theme-field

Nov 3, 2023

+17 −22

Member

dbauszus-glx commented Oct 30, 2023

Use the feature ID from the properties if no distinct field is defined for the distributed theme.


          Use ID if field is undefined in theme.

dbauszus-glx requested review from cityremade, RobAndrewHurst, simon-leech and eo-uk

October 30, 2023 15:09

dbauszus-glx added the Bug label

Member

cityremade commented Nov 2, 2023 •

edited

Loading

It works correct when .field is undefined however in the reported case it's the value of the defined field which is null.
If we have nulls in the column used by the theme all features get the first colour. Should null be a value in the theme that would get its own colour?

** Another solution would be to prevent null values on the database side as the field in question is calculated by an algorithm.

cityremade requested changes

View reviewed changes

Member

cityremade left a comment

Needed support for theme field defined but of null value.


          use 0 instead of undefined or null.

65ae9d9

dbauszus-glx requested a review from cityremade

November 2, 2023 13:09

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

cityremade approved these changes

View reviewed changes

Member

cityremade left a comment

so as I said I am approving this as correct. The rest of the issue is on the data science side.

dbauszus-glx merged commit fd75ac6 into GEOLYTIX:main

6 checks passed

dbauszus-glx deleted the distributed-theme-field branch

January 29, 2024 09:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug