Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a Query to Set the Edit Options #989

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Allow a Query to Set the Edit Options #989

merged 1 commit into from
Nov 1, 2023

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Oct 31, 2023

This PR is a simple change, in PR #930 we added the ability to use an empty edit.options array that would then run the distinct_values template on the database.
This PR simply allows the configuration developer to optionally provide an entry.edit.query that will instead be used to populate the entry.edit.options.
This is required as is it possible the options come from a different column / different table entirely, especially if a table is initially empty no options will be provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@simon-leech simon-leech marked this pull request as ready for review October 31, 2023 13:04
@simon-leech simon-leech added the Feature New feature requests or changes to the behaviour or look of existing application features. label Oct 31, 2023
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dbauszus-glx dbauszus-glx merged commit 952a878 into GEOLYTIX:main Nov 1, 2023
6 checks passed
@simon-leech simon-leech deleted the edit-options-query branch February 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants