Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no_result configuration for gazetteer. #992

Merged
merged 2 commits into from
Nov 8, 2023
Merged

no_result configuration for gazetteer. #992

merged 2 commits into from
Nov 8, 2023

Conversation

dbauszus-glx
Copy link
Member

Setting no_result in the gazetteer config will display the value as no result message instead of the default from the dictionary.

Setting no_result as null will display no message.

@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Nov 6, 2023
cityremade
cityremade approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@cityremade cityremade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does the job for me. I can set this flag to null on each dataset to prevent 'no result' messages.

simon-leech
simon-leech previously requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbauszus-glx Please can you add this to the Config Docs?
https://github.com/GEOLYTIX/xyz/wiki/Workspace-Configuration#gazetteer

@RobAndrewHurst
Copy link
Contributor

Adding in the no_result property in the root of the gazetteer doesn't remove the message

image

image

@dbauszus-glx
Copy link
Member Author

@RobAndrewHurst should be fixed in last commit.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

RobAndrewHurst
RobAndrewHurst approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice easy change!

Works for both an entire gazetteer, or a specific dataset.

@RobAndrewHurst RobAndrewHurst dismissed simon-leech’s stale review November 8, 2023 05:52

Its been added into the documentation :)

@RobAndrewHurst RobAndrewHurst merged commit cf5ded3 into GEOLYTIX:main Nov 8, 2023
6 checks passed
@dbauszus-glx dbauszus-glx deleted the gazetteer-no-result branch January 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAndrewHurst RobAndrewHurst RobAndrewHurst approved these changes

@cityremade cityremade cityremade approved these changes

@eo-uk eo-uk Awaiting requested review from eo-uk

@simon-leech simon-leech Awaiting requested review from simon-leech

Assignees
No one assigned
Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbauszus-glx @RobAndrewHurst @cityremade @simon-leech