-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync fields; Geometry edit updates; Boolean Fields #993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this one out -
✅ hideNoEdit works well and is a great user improvement for points where geometry checkbox doesn't do anything
✅dependents are now being updated for geometry editing
✅ dependents are updated for non-geometry editing
✅ boolean fields now show a tick or cross when true or false, and edit still works.
❔ Should null values from the db in integer and numeric types be parsed to a number - at the moment they show as NaN which isn't very good for the user?
❔ Please can you update the Config Docs with the new options?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Added to config wiki.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dbauszus-glx working for me - happy with this one!
The
location.syncFields(fields)
will get the values and update entries for the fields argument.The
location.update()
and the geometry entry update methods will call the syncFields metthod for theirdependents[]
fields.The geometry entry update method will rebuild the remove and rebuild the location
viewEntries
.The numeric entry will not format the entry.value but only format the render if the entry is not editable.
The boolean, numeric, and text entries will assign the newValue if rebuild with editing enabled.
The
.link-with-img
css nesting has been fixed for the lineheight.The geometry entry method will shortcircuit id not editable with the
hideNoEdit
flag set in the entry config.The boolean entry will not return a disabled checkbox but an icon inline with the label if not editable.