Locations/entries/date - now takes user local time; #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved problem of displayed value, unix epochs and formatting for the input of type date.
|
Kudos, SonarCloud Quality Gate passed!
|
dbauszus-glx
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Excellent. Works well.
Things I changed in review is const use instead of let.
Naming from d to dateString and t to timeString.
I removed the commented code.
Value should be null if non editable and null.
Value must be taken from newValue if available in edit mode. The view may rebuild from the update of dependents with edits not yet saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved problem of displayed value, unix epochs and formatting for the input of type date.
Works well for me - I see my local time and the unix epoch saved in the db is correct.
Let me know if it works for you as you are both in different timezones.