Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get nonlanguage [view] templates #998

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

dbauszus-glx
Copy link
Member

View templates (e.g. reports) may not be language templates and should be got from the getTemplates module.

The view endpoint should return 400 instead of crashing the process if template is undefined.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Nov 10, 2023
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the described bug for me - custom views are no longer crashing

@RobAndrewHurst RobAndrewHurst merged commit 346fedf into GEOLYTIX:main Nov 13, 2023
6 checks passed
@dbauszus-glx dbauszus-glx deleted the nonlanguage-templates branch January 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants