Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified components.yaml to enable a PR for @RRG and radition mods #827

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

msl3v
Copy link

@msl3v msl3v commented Oct 1, 2024

Top-level mods for integrating RRG and mods to RRTMG for radiation diagnostics

@msl3v msl3v requested a review from a team as a code owner October 1, 2024 21:27
@msl3v msl3v closed this Oct 1, 2024
@msl3v msl3v reopened this Oct 1, 2024
@sdrabenh
Copy link
Collaborator

sdrabenh commented Oct 2, 2024

Top-level mods for integrating RRG and mods to RRTMG for radiation diagnostics

@msl3v please provide more details on what these new changes enable/support

@msl3v msl3v added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 2, 2024
@msl3v
Copy link
Author

msl3v commented Oct 3, 2024

@sdrabenh There are two primary changes in this set of PRs.

  1. Radiatively Relevant Gases (RRG) Gridcomp: This gridcomp was developed to supercede GOCART for GHG modeling in GEOS. This PR is the 1st formal introduction of RRG into the GEOS-ESM base. There are no gridcomps that currently depend on RRG by default. It lives in @GEOSchem_GridComp

  2. RRTMG:
    a) The RRTMG longwave radiation module was modified to receive 3D CO2 fields for LW forcing. CO2 can be provided by either GOCART or RRG. The default settings were not modified
    b) A "double-call" was added to the RRTMG LW module that enables online computation of GHG-specific LW radiative forcing diagnostics for any of the RAT gases (CO2, CH4, CFCs, N2O, etc...)

@mathomp4 mathomp4 added the Non 0-diff The changes in this pull request are non-zero-diff label Oct 10, 2024
@mathomp4
Copy link
Member

mathomp4 commented Oct 10, 2024

NOTE for @sdrabenh I am adding a non-zero-diff label because this is technically non-zero-diff. The reason is that the mslong/rrg+rad branch of GEOSchem_GridComp based off of develop which is non-zero-diff to GEOSchem_GridComp v1.14 (due to updated QFED emissions, see #803).

If one uses all these branches but reverts to the older QFED emissions it is zero-diff as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants