Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major fixes to enable EASY coupled model experiments #538

Merged
merged 12 commits into from
Nov 29, 2023

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Nov 16, 2023

The intent of this PR is to make our life simple(r) in setting up GEOS coupled model experiments for all of these resolution combinations.

Proposed changes:

  1. The default ocean model for gcm_setup is MOM6. ✅ @sanAkel
  2. Use the BCs shared path on discover: /discover/nobackup/projects/gmao/bcs_shared/make_bcs_inputs/ocean/MOM6/ to pick up files needed by MOM6 ✅ @sanAkel
  3. To do@mathomp4 Layout needs to be made consistent.
  4. To do@mathomp4 Options needed to be locked up with the atmosphere as in this table.

Details of what needs to be done.

Layout:

AGCM.rc NX x NY should match MOM’s LAYOUT listed in MOM_override see this table or ⬇️ .

AGCM NX x NY and OGCM NX x NY need to be fixed in AGCM.rc in the following manner:

Configuration Name AGCM (NX x NY) OGCM (NX x NY) Layout in MOM_override
Low 1 x 6 3 x 2 3 x 2
Medium 5 x 36 90 x 2 90 x 2
High 30 x 36 36 x 30 36 x 30

Options:

See following example for setting up high resolution experiment:

discover13.sakella 1046> gcm_setup

Enter the Experiment ID:
testH
Enter a 1-line Experiment Description:
test
Do you wish to CLONE an old experiment? (Default: NO or FALSE)

Enter the Atmospheric Horizontal Resolution code:
--------------------------------------
            Cubed-Sphere
--------------------------------------
   c12  -- 8    deg (750.0    km) 
   c24  -- 4    deg (375.0    km) 
   c48  -- 2    deg (187.5    km) 
   c90  -- 1    deg (100.0    km) 
   c180 -- 1/2  deg ( 50.0    km) 
   c360 -- 1/4  deg ( 25.0    km)  
   c720 -- 1/8  deg ( 12.5    km) 
   c1440 - 1/16 deg (  6.25   km) 
   c2880 - 1/32 deg (  3.125  km) 
   c5760 - 1/64 deg (  1.5625 km) 
            CONUS Stretched Grids                
   c270 -- ( 16.0 -100 km)  
   c540 -- (  8.0 - 50 km)  
   c1080 - (  4.0 - 25 km)  
   c1536 - (  2.0 - 20 km)  
   c2160 - (  2.0 - 12 km)  
 
c180
Enter the Atmospheric Model Vertical Resolution: LM (Default: 72)

Enter Choice for Atmospheric Model Microphysics: (Default: BACM_1M)
   BACM_1M  --  3-phase 1-moment Bacmeister et al
   GFDL_1M  --  6-phase 1-moment Geophysical Fluid Dynamics Laboratory
   MGB2_2M  --  5 or 6-phase 2-moment Morrison & Gettleman

Use Hydrostatic Atmosphere? (Default: TRUE)

Do you wish to IOSERVER? (Default: YES or TRUE)

Enter the Processor Type you wish to run on:
   mil  (Milan) (default)
 

Do you wish to run the COUPLED Ocean/Sea-Ice Model? (Default: NO or FALSE)
YES

Choose an Ocean Model: (Default: MOM6)
   MOM5
   MOM6
   MIT

Choose a Seaice Model: (Default: CICE4)
   CICE4
   CICE6

Enter the Ocean Lat/Lon Horizontal Resolution: IM JM (Default: 360 210)
1440 1080
Enter the Ocean Model Vertical Resolution: LM (Default: 50)
75
Enter the choice of  Land Surface Boundary Conditions using: 1 (Icarus), 2 (Default: Icarus-NLv3)
...
...

The user does not need to answer: Enter the Ocean Lat/Lon Horizontal Resolution: IM JM (Default: 360 210): 1440 1080 and Enter the Ocean Model Vertical Resolution: LM (Default: 50): 75. Since a choice was made to run:

  • With C180 atmospheric resolution
  • And Coupled.

This table provides only one option for ⬆️ choices, hence that should be automatically populated. It can simply echo that it has been filled in.

Similarly for C90 and C12.

@sanAkel sanAkel added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 16, 2023
@sanAkel sanAkel self-assigned this Nov 16, 2023
@sanAkel sanAkel added the enhancement New feature or request label Nov 20, 2023
…ue enough and therefore works! Thank you @sdrabenh for suggesting it.
@sanAkel sanAkel removed the request for review from mathomp4 November 21, 2023 23:18
@sanAkel sanAkel marked this pull request as ready for review November 21, 2023 23:18
@sanAkel sanAkel requested a review from a team as a code owner November 21, 2023 23:18
yvikhlya
yvikhlya previously approved these changes Nov 22, 2023
@sanAkel
Copy link
Collaborator Author

sanAkel commented Nov 22, 2023

⬆️ Items 3 and 4 will be addressed via #542 (review)

@sanAkel
Copy link
Collaborator Author

sanAkel commented Nov 23, 2023

We need this PR to be merged as well for all the High configuration to be set up automatically.

@mathomp4
Copy link
Member

I've merged in #542 into here. Something is missing and I'm not sure what. But maybe I didn't branch right...

@sanAkel
Copy link
Collaborator Author

sanAkel commented Nov 27, 2023

I've merged in #542 into here. Something is missing and I'm not sure what. But maybe I didn't branch right...

@mathomp4 Is it something I can help with?

@mathomp4
Copy link
Member

mathomp4 commented Nov 27, 2023

I've merged in #542 into here. Something is missing and I'm not sure what. But maybe I didn't branch right...

@mathomp4 Is it something I can help with?

CI failed to run in my branch. Not sure why. So I merged mine over here to see if maybe I was missing something. If that fails, I'll get on to the cloud instance and see what I see...

Ah. I see why. This PR is broken on every system but NCCS. I'll need to work on this. One moment.

@mathomp4
Copy link
Member

Okay. One more push...

@mathomp4
Copy link
Member

Yay! 🎉

@sanAkel
Copy link
Collaborator Author

sanAkel commented Nov 28, 2023

Fantastic! :)

Copy link
Collaborator

@sdrabenh sdrabenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as discussed herein

@sdrabenh sdrabenh merged commit 1f62b47 into develop Nov 29, 2023
10 checks passed
@sdrabenh sdrabenh deleted the feature/sanAkel/fix_update_coupled-set-up branch November 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants