Reverted fv_tracer2d.F90 to version geos/1.5.0 to get around the laoyut regression caused by dyncore #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut regression caused by dyncore
aoloso
added
bug
aoloso
changed the title
mathomp4
approved these changes
Nov 28, 2023
|
Oh, and thanks to @aoloso for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stock c180 run fails to regress with layout. Two runs of the same setup at c180 or higher resolution but different NX by NY decompositions are not zero-diff. The problem was found to be with tracer_2d_1L subroutine in fv_tracer2d.F90. Reverting back to the version of fv_tracer2d in geos/v1.5.0 fixes the problem. Minor change to fv_dynamics.F90 to remove the now unused variable z_pack was also made.