Update fv_grid_tools.F90 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When introducing non-global mechanism for computing coordinates, a copy-paste mistake broke the Schmidt transform. Does not affect legacy coordinate algorithm. Basically the loop over tiles should just be a single iteration for the local tile. Obvious in hindsiht.
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bug |
1 similar comment
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bug |
|
@tclune Is this zero-diff (in that it only affects the local-transform path)? |
|
Yes - zero diff for "legacy" mode. And zero diff for new when not using stretch. |
tclune
added
the
0 diff
mathomp4
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing non-global mechanism for computing coordinates, a copy-paste mistake broke the Schmidt transform. Does not affect legacy coordinate algorithm.
Basically the loop over tiles should just be a single iteration for the local tile. Obvious in hindsight.